Allow build image with local changes for debug purpose #247

taoyl-ms · 2017-02-03T03:16:41Z

No description provided.

jleveque · 2017-02-03T04:21:31Z

build_image.sh

+if [ -z "$(git status --untracked-files=no -s --ignore-submodules)" ]; then 
+    GIT_REVISION=$(git rev-parse --short HEAD)
+else
+    echo "Warning: There is local changes not committed to git repo. Cannot get a revision hash for partition metadata."


"Warning: There are local changes not committed to..." #Resolved

you can always do local commit, it is git. #WontFix

For development it is not comfortably to keep in mind that after each change local commit should be performed.
Another think is if build is run in second time sub-modules will have untracked files:

git status ... modified: src/lldpd (modified content, untracked content) modified: src/sonic-linux-kernel (untracked content) modified: src/sonic-quagga (modified content, untracked content) modified: src/sonic-sairedis (untracked content) modified: src/sonic-swss (untracked content) modified: src/sonic-swss-common (untracked content) ...

This also will cause "build_image.sh" fail. #Closed

ok. I then we need to avoid this in the official build. It is important for us to debug. I would suggest to have an option in rules/config to turn on/off this check.

for example,
ENFORCE_CLEAN_BUILD = y #Resolved

for dev env, you can turn it off, and it just prints out warning. If the option is yes, then it will break the build. #Resolved

We have "--untracked-files=no" so those untracked files in submodules won't break the build.
But I do agree with you that we should not force dev to commit everything before build the code, because, 1) the change might only be a temporary one, like adding some debug printing that you would definitely remove soon. Make a commit for those change will make debug process much more complicated. 2) if you are generating a build based on local changes, it's better to have "local build" information in the image version rather than only a git hash pointing to a local commit that other people will find it nowhere.

In reply to: 99333402 [](ancestors = 99333402)

agree. will work on that.

In reply to: 99337285 [](ancestors = 99337285)

We have "--untracked-files=no" so those untracked files in submodules won't break the build.
But I do agree with you that we should not force dev to commit everything before build the code, because, 1) the change might only be a temporary one, like adding some debug printing that you would definitely remove soon. Make a commit for those change will make debug process much more complicated. 2) if you are generating a build based on local changes, it's better to have "local build" information in the image version rather than only a git hash pointing to a local commit that other people will find it nowhere.

taoyl-ms · 2017-02-04T01:43:45Z

added a control flag according to CR.
make DEBUG_BUILD=true will now allow building image with local changes.

stcheng · 2017-02-04T03:52:25Z

Makefile

@@ -31,6 +31,7 @@ DOCKER_BUILD = docker build --no-cache \
 	    -f slave.mk \
 	    PLATFORM=$(PLATFORM) \
 	    SKU=$(SKU) \
+            DEBUG_BUILD=$(DEBUG_BUILD) \


one more space #Resolved

lguohan · 2017-02-05T02:19:17Z

Makefile

@@ -31,6 +31,7 @@ DOCKER_BUILD = docker build --no-cache \
 	    -f slave.mk \
 	    PLATFORM=$(PLATFORM) \
 	    SKU=$(SKU) \
+            DEBUG_BUILD=$(DEBUG_BUILD) \


can you add this into rules/config? #Resolved

don't quite get you. In default we are having this option off now. That should be the correct default behavior right?

In reply to: 99479772 [](ancestors = 99479772)

in the rules/config file, and a build option
DEBUG_BUILD = n

by default, we do not enable debug_build. You can also change it to DEBUG_BUILD=y #Resolved

swss: * e34104e 2018-04-13 | [pfcwd]: support BIG_RED_SWITCH mode (#467) (HEAD, origin/201803) [sihuihan88] * 1f857d5 2018-04-25 | [buffermgr]: remove the item from consumer queue if invalid (#489) [sihuihan88] utilities: * 0b9bb2b 2018-04-26 | Stop services before pushing new config during "load_minigraph" (#247) (HEAD, origin/201803) [Prince Sunny] * dc119c9 2018-04-18 | [show logging] For following, change 'tail -f' to 'tail -F' in order to retry in the case log is rotated (#240) [Joe LeVeque] * 08da428 2018-04-16 | [pfcwd]: add cli to enable/disable BIG_RED_SWITCH mode (#237) [sihuihan88] Signed-off-by: Guohan Lu <gulv@microsoft.com>

* Add nbrmgr to supervisord conf * Corrected priority values [Fix typo] * Submodule update for Neighbor manager daemon Submodule update sonic-swss-common: edbfeec - Remove default docker name value of swss. (#250) 9728462 - Corrected configDB name for neigh table (#251) 6decc65 - Add NEIGH_TABLE to configDB for neighbor configuration (#249) 9918ae6 - Add ProducerStateTable temp view implementation and UT (#247) 41408f2 - Update README on dependencies d9c0ba4 -Update README on the section 'Build with Google Test' bb7fa5b - [ut]: explicit convert is to bool type (#248) 661b82c - Add gtest instruction in README Submodule update sonic-swss 705b092 - Support ConfigDB neighbor configuration, introduce nbrmgr daemon (#693) 8522390 - Add vxlan switch attributes to switch orch (#712) b123fa0 - [schema] update WARM_RESTART_TABLE:process_name schema document (#707) 2d7ab0c - Revert "Align default MTU value as SAI default (#705)" (#710) 836a58c - Align default MTU value as SAI default (#705) bffa01f - VNET/VXLAN changes (#643) b750a4b - [watermarkorch] add watermarkorch, extend queue and pg counters with wat\u2026 (#629)

…c-net#247) * Stop sonic services before pushing new config * Address comments. Stop service during config reload

[installer]: Suppress tar xz warning about time stamp in the future, if date is not correctly set (sonic-net#1562) \[sonic-platform-common\] Update submodule (sonic-net#1563) \- Includes the following commits: \- \[bcmshell.py\] Match extra whitespace before prompt in regex (#3) \- add support for qsfp28 eeprom (#2) \[baseimage\]: bring down eth0 before restart networking (sonic-net#1555) cfggen generates new eth0 configuration. Need to first clean existing configuration on eth0 before bring up new configuration on eth0. Thus, we need to first bring down eth0 before putting new configuration into /etc/network/ interfaces \[mellanox\]: Update MLNX SAI pointer (sonic-net#1557) \[minigraph.py\] Add support to parse tacacs server information (sonic-net#1549) \* \[minigraph.py\] Add support to parse tacacs server information \[router advertiser\] Only start radvd process if device role is 'ToRRouter' (sonic-net#1569) \[submodules\]: update sonic-swss (sonic-net#1570) \[submodules\]: update sonic-utilities (sonic-net#1571) \[cfggen\]: ignore acl when its type is not defined (sonic-net#1568) \[installer\]: Umount before delete partition (sonic-net#1575) Use eth0 interface only to generate lldpd SystemId (sonic-net#1577) Allow one Service ACL to bind to multiple services (sonic-net#1576) \* \[caclmgrd\] Also ignore IP protocol if found in rule; we will only use our predefined protocols \[snmp\]: Bind snmpd to all ip addresses (sonic-net#1587) \[device\] Update Arista driver submodule (sonic-net#1585) Watchdog timeout increased \[devices\]: Fix type for qos.json in 7060 and S6100 (sonic-net#1582) \[minigraph\]: ignore minigraph ports which are not in port_config.ini (sonic-net#1593) \[minigraph\] Fix parser on PNG DeviceInterfaceLink Bandwidth (sonic-net#1592) \* \[minigraph\] Fix parser on PNG DeviceInterfaceLink Bandwidth \[Broadcom SAI\] upgrade Broadcom SAI to version 3.1.3.4-10 (sonic-net#1591) \* \[Broadcom SAI\] upgrade Broadcom SAI to version 3.1.3.4-9 Includes configuration files for following devices: \- Quanta 1X1B-32X \- Dell Z9264F \- Inventec D7054Q28B and D7032Q28B \* \[bcm sai\] upgrade sai version to 3.1.3.4-10 include configuration change to 7060 T0. 50G support for Arista 7060 (sonic-net#1580) \* 50G SKU for Arista 7060 Marvell's updates for SONiC 201803 over SAI v1.2 (sonic-net#1588) \[Mellanox\] Add support for a new platform LS-SN2700 \[devices\]: Merge ingress service pools of lossless and lossy traffic for TD2 (sonic-net#1578) \[sonic-utilities\] add pfcstat and queuestat tool (sonic-net#1606) Add support for S6100 switchport LEDs (sonic-net#1610) \[ip-in-ip\]: Fix config template to apply correct platform depended values (sonic-net#1619) \[platform-common\]: Update sonic-platform-common submodule (sonic-net#1620) \[sfputilbase\]: Add logic to parse the title of port_config.ini file \[sonic-cfggen\] Be case insensitive to hostname in minigraph (sonic-net#1614) \[bugfix\]: pass correct port name to led_control.py in ledd \[cfggen\]: Fix build by fixing pyangbind version (sonic-net#1633) \[swss\]: update sonic-swss submodule \* ea34b92 2018-04-24 | Fix tables handling race condition in buffermgr (sonic-net#484) (HEAD -> 201803, origin/201803) \[Andriy Moroz\] \* 53831be 2018-04-19 | \[pfcwd\]: create PFCWD acl instead of L3 ACL (sonic-net#479) \[sihuihan88\] \[radvd\] Ensure at least one interface is specified in radvd.conf before starting radvd (sonic-net#1636) \[updategraph\]: Keep updategraph service active after start (sonic-net#1651) \[docker-lldpd\]: Various fixes (sonic-net#1650) \* We don't need configure anything until we have interfaces created \* Don't run lldpcli for a port, until a port is up and running \* Remove lldpd socket before starting lldpd \* Fix sample files for lldpd configuration \* Another attempt to make the test working \* Quick fix for lldpd paused after start bug \[submodules\]: update swss and utilities modules swss: \* e34104e 2018-04-13 | \[pfcwd\]: support BIG_RED_SWITCH mode (sonic-net#467) (HEAD, origin/201803) \[sihuihan88\] \* 1f857d5 2018-04-25 | \[buffermgr\]: remove the item from consumer queue if invalid (sonic-net#489) \[sihuihan88\] utilities: \* 0b9bb2b 2018-04-26 | Stop services before pushing new config during "load_minigraph" (sonic-net#247) (HEAD, origin/201803) \[Prince Sunny\] \* dc119c9 2018-04-18 | \[show logging\] For following, change 'tail -f' to 'tail -F' in order to retry in the case log is rotated (sonic-net#240) \[Joe LeVeque\] \* 08da428 2018-04-16 | \[pfcwd\]: add cli to enable/disable BIG_RED_SWITCH mode (sonic-net#237) \[sihuihan88\] \[snmp\]: Fix a race between snmpd-config-updater and snmpd (sonic-net#1628) There is a small window in which snmpd might not have registered a callback for SIGHUP and which will result in its death if snmpd-config-updater send this signal meant for a config reload. \[snmpd\]: Fix typo in is_platform_arista (sonic-net#1634) \[mellanox\]: Update SAI version to 1.11.4 and SDK to 4.2.7303 (sonic-net#1655) \[docker-dhcp\]: Fix the sonic build issue (sonic-net#1659) Install the built version of isc-dhcp-client in docker-dhcp-relay \[swss\]: update swss 118b3f0 2018-05-01 | Populate existing interface cache, bring down before configDone \[zebra.conf\] Fix template issue with multiple lo addresses (sonic-net#1662) \* \[zebra.conf\] Fix template issue with multiple lo addresses \* Add unitest for Loopback1 \[swss\]: Change the hash seed to 0 for ToR and 10 for Leaf routers (sonic-net#1667) Due to some ASIC platform limitations, the hash seed range is from 0 to 15. Thus the switch.json.j2 template is updated so that ToRRouter is using hash seed 0 and LeafRouter is using hash seed 10. \[snmp\]: Stop spamming logs with statfs permission denied log message (sonic-net#1668) \[broadcom\]: update broadcom SAI to 3.1.3.4-11 (sonic-net#1670) Provide better ECMP load-balancing via hash seed \[sonic-cfggen\]: fix bgpd and zebra template for sonic-cfggen test I took the original patch (bebb7a0) into 201803 branch need to also adapt the patch since we do not have commit (d423841) in 201803 branch. \[swss\]: update sonic-swss module \[201803 d57f9a1\] \[lua\]: use not to check whether the field exists (sonic-net#492) \[device\] Update arista driver submodule (sonic-net#1674) \[submodule\]: Update submodule sonic-snmpagent (sonic-net#1642) sonic-cfggen supports hwsku parameter (sonic-net#1631) \*Note\*: tuned test data during cherry-pick \[device\] Add PSU utility for platform ly1200 of MiTAC (sonic-net#1673) \[platform/broadcom/sonic-platform-modules-mitac\] Install acpi package for daemon and adjust i2c sequence \[mellanox\]: Update MLNX SAI pointer (sonic-net#1684) 40G profile for Arista 7060 (sonic-net#1677) Update buffers config for Mellanox 27xx devices (sonic-net#1649) \* Update buffers config for Mellanox 27xx devices \* Remove buffers template test for msn27xx \[submodule\]: Update submodule sonic-snmpagent: Improve mib fundamental classes (sonic-net#1689) \[sonic-utilities\]: update sonic utilities submodule \* 951633b 2018-05-04 | \[generate_dump\]: fix a saidump file copy bug (sonic-net#248) (HEAD, origin/201803) \[Kebo Liu\] \* 69baff7 2018-05-03 | \[acl_loader\]: Missing one colon (sonic-net#252) \[Shuotian Cheng\] \* 557248d 2018-05-02 | \[acl-loader\]: Add --table_name option to update full operation (sonic-net#249) \[Shuotian Cheng\] \* a8aadee 2018-04-30 | \[acl-loader\]: Change the header from Rule ID to Table (sonic-net#250) \[Shuotian Cheng\] \[swss\]: update sonic-swss \* b57c376 2018-05-10 | \[teamsyncd\]: Add team_ifindex2ifname return value check (sonic-net#500) (HEAD, origin/201803) \[Shuotian Cheng\] \* 236843f 2018-05-07 | Fix Crm Acl used counter update (sonic-net#496) \[Nadiya\] \[swss\]: update sonic-swss c374357 2018-04-23 | Fix ZeroBufferProfile parameters (sonic-net#485) (HEAD -> 201803) \[Andriy Moroz\] \[platform\]: Fixed Cavium platform modules build. (sonic-net#1694) \[submodule\]: Update submodule sonic-snmpagent: Improve mib fundamental classes: retry after reinit_data() throws (sonic-net#1700) Merge branch 'github-1803' Conflicts: dockers/docker-router-advertiser/start.sh platform/broadcom/sai.mk platform/mellanox/mlnx-sai.mk src/sonic-config-engine/sonic-cfggen src/sonic-config-engine/tests/sample_output/ports.json src/sonic-config-engine/tests/test_cfggen.py src/sonic-platform-daemons src/sonic-snmpagent src/sonic-swss src/sonic-utilities \[baseimage\]: Disable DAD for eth0 explicitly (sonic-net#1701) \[quagga\]: update quagga submodule (sonic-net#1698) \* \[quagga\]: update quagga submodule 0bc6bd6 2018-05-11 | ignore nexthop attribute when NLRI is present (#18) (HEAD, origin/debian/0.99.24.1, origin/HEAD) \[lguohan\] \* add vs bgp test Fix the build error Revert "\[sonic-cfggen\]: fix bgpd and zebra template for sonic-cfggen test" This reverts commit b29d835. Fix the build issue for sonic-cfggen test Merge branch 'github-1803' --5/12 Conflicts: src/sonic-quagga src/sonic-snmpagent RB=1312391 G=lnos-reviewers R=pchaudha,pmao,rmolina,zxu A=

* Add get_stats SAI API support Signed-off-by: marian-pritsak <marianp@mellanox.com> * Support for PG stats Signed-off-by: marian-pritsak <marianp@mellanox.com> * Address comments Signed-off-by: marian-pritsak <marianp@mellanox.com> * Change from macro to template Signed-off-by: marian-pritsak <marianp@mellanox.com> * Simplify traits Signed-off-by: marian-pritsak <marianp@mellanox.com>

c2aac75 [SFP-Refactor] Fix LP mode API issue (#247) dba17c8 Firmware upgrade CLI support for QSFP-DD transceivers (#244) cd69212 [SFP-Refactor] Implement CMIS Low Power mode (#237) 9cea07f Fix RegGroupField decode (#245) 6ae1909 Add CMIS QSFP support (#246) c1f317d Gracefully handle CMIS APIs for passive modules (#238) ec7335d fix for firmware functions (#243) cf2ebe9 Fix RegBitField decode/encode (#242) ef4f2c6 Fix SFP_CABLE_TECH_FIELD (#240) e118644 remove time counting message in functions because function running time could be difficult to predict in unit tests (#241) Signed-off-by: Prince George <prgeor@microsoft.com>

99aebb601fece23bc54a7597410ff7469a7faeb3 Fix platform daemon chassisd to handle auto restart on fail (#247)

9ac12bf (HEAD -> master, origin/master, origin/HEAD) Fix platform daemon chassisd to handle auto restart on fail (sonic-net#247) 24fba04 [ycable] fix the logic to update cable_info values when ycable is not present; fix read side logic for ycable (sonic-net#249)

9ac12bf (HEAD -> master, origin/master, origin/HEAD) Fix platform daemon chassisd to handle auto restart on fail (#247) 24fba04 [ycable] fix the logic to update cable_info values when ycable is not present; fix read side logic for ycable (#249)

Update overview section for Telemetry_Subscribe_Paths.md

Includes below commits ``` 1477c36 2022-05-04 | Fix: if routestr does not exist, skip (#257) [Qi Luo] 5c08435 2022-05-04 | Add VoQ Recirc interface (i.e., Ethernet-Rec) to interface maps for S… (#244) [Song Yuan] 57f1af6 2022-05-02 | Fix: not to use blocking get_all() after keys() (#255) [Qi Luo] 33fdf9d 2022-04-06 | [RFC2737, RFC3433] Exclude RJ45 port from Entity MIB and Entity sensor MIB (#247) [Kebo Liu] ```

Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683

Includes below commits ``` 1477c36 2022-05-04 | Fix: if routestr does not exist, skip (sonic-net#257) [Qi Luo] 5c08435 2022-05-04 | Add VoQ Recirc interface (i.e., Ethernet-Rec) to interface maps for S… (sonic-net#244) [Song Yuan] 57f1af6 2022-05-02 | Fix: not to use blocking get_all() after keys() (sonic-net#255) [Qi Luo] 33fdf9d 2022-04-06 | [RFC2737, RFC3433] Exclude RJ45 port from Entity MIB and Entity sensor MIB (sonic-net#247) [Kebo Liu] ```

…t#247) Description Add signal handlers correctly and fix clean up so that the auto restart works ok on signals. Motivation and Context Add signal handlers correctly and fix clean up so that the auto restart works ok on signals. How Has This Been Tested? Verified by running again chassis LC.

* [SFP-Refactor] Fix LP mode API issue * update API

…0.40 kernel (sonic-net#247) When upgrading from Linux 4.19.x to 5.10.40, cisco-hwmon-pmbus_core-pec-support-check.patch was disabled, as it did not apply cleanly. Forward port it to Linux 5.10.40 and add it to the Linux 5.10 patch series. Test on cisco-8000 platform: ``` root@localhost:/home/cisco# show plat temp Sensor Temperature High TH Low TH Crit High TH Crit Low TH Warning Timestamp CPU_U17_P1P05V_TEMP 35.187 125 -5 135 -10 False 20211011 13:57:45 CPU_U17_PVCCIN_TEMP 34.937 125 -5 135 -10 False 20211011 13:57:45 CPU_U117_P1P2V_TEMP 30.75 125 -5 135 -10 False 20211011 13:57:46 CPU_U117_P1P05V_TEMP 31 125 -5 135 -10 False 20211011 13:57:46 DIMM_TEMP1 28.25 125 -5 135 -10 False 20211011 13:57:47 FAN_Sensor 32.375 97 -5 102 -10 False 20211011 13:57:45 MB_3_3V_L_TEMP_L1 33.187 125 -5 135 -10 False 20211011 13:57:47 MB_3_3V_L_TEMP_L2 33.187 125 -5 135 -10 False 20211011 13:57:47 MB_3_3V_R_VDDCK_TEMP_L1 34.187 125 -5 135 -10 False 20211011 13:57:46 MB_3_3V_R_VDDCK_TEMP_L2 48.312 125 -5 135 -10 False 20211011 13:57:46 MB_GB_CORE_TEMP_L1 43.312 110 -5 115 -10 False 20211011 13:57:47 MB_PORT_Sensor 22.563 120 -5 125 -10 False 20211011 13:57:45 MB_TMP421_Local 25 120 -5 125 -10 False 20211011 13:57:45 MB_VDDS_VDDA_TEMP_L1 48.125 125 -5 135 -10 False 20211011 13:57:46 MB_VDDS_VDDA_TEMP_L2 50.562 125 -5 135 -10 False 20211011 13:57:46 PSU0 HSNK_Temp1 28.75 91 -5 96 -10 False 20211011 13:57:47 PSU0 HSNK_Temp2 28.25 110 -5 115 -10 False 20211011 13:57:47 PSU0 Inlet_Temp 27.5 80 -5 85 -10 False 20211011 13:57:47 PSU0 Outlet_Temp 31.75 108 -5 110 -10 False 20211011 13:57:47 PSU1 HSNK_Temp1 29 91 -5 96 -10 False 20211011 13:57:47 PSU1 HSNK_Temp2 28.25 110 -5 115 -10 False 20211011 13:57:47 PSU1 Inlet_Temp 26.5 80 -5 85 -10 False 20211011 13:57:47 PSU1 Outlet_Temp 30.75 108 -5 110 -10 False 20211011 13:57:47 SSD_Temp 25 80 -5 85 -10 False 20211011 13:57:47 X86_CORE_0_T 37 125 -5 135 -10 False 20211011 13:57:45 X86_CORE_1_T 38 125 -5 135 -10 False 20211011 13:57:45 X86_CORE_2_T 37 125 -5 135 -10 False 20211011 13:57:45 X86_CORE_3_T 37 125 -5 135 -10 False 20211011 13:57:45 X86_PKG_TEMP 38 125 -5 135 -10 False 20211011 13:57:45 root@localhost:/home/cisco# ``` Signed-off-by: Madhava Reddy Siddareddygari msiddare@cisco.com

…ic-utilities [submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically

Allow build with local change for debug purpose

65b9453

jleveque reviewed Feb 3, 2017

View reviewed changes

Modify according to CR comments

43e6077

stcheng reviewed Feb 4, 2017

View reviewed changes

lguohan requested changes Feb 5, 2017

View reviewed changes

Modify according to CR comments

e2bbd8d

taoyl-ms self-assigned this Feb 10, 2017

lguohan approved these changes Feb 15, 2017

View reviewed changes

taoyl-ms merged commit f5b2dcc into sonic-net:master Feb 15, 2017

prsunny mentioned this pull request Nov 28, 2018

Add nbrmgr to supervisor control #2265

Merged

madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020

use vlan oid instead of vlan id (sonic-net#247)

83363a7

judyjoseph mentioned this pull request Apr 8, 2022

Update sonic platform daemons #10514

Merged

6 tasks

judyjoseph added a commit that referenced this pull request Apr 11, 2022

Update sonic-platform-daemons

58fa185

99aebb601fece23bc54a7597410ff7469a7faeb3 Fix platform daemon chassisd to handle auto restart on fail (#247)

sg893052 pushed a commit to sg893052/sonic-buildimage that referenced this pull request Apr 25, 2022

Merge pull request sonic-net#247 from sachinholla/subscribe_paths

4b98c4d

Update overview section for Telemetry_Subscribe_Paths.md

vdahiya12 mentioned this pull request May 31, 2022

[sonic-platform-common][sonic-platform-daemons]submodule update #10993

Merged

6 tasks

snider-nokia pushed a commit to snider-nokia/sonic-buildimage that referenced this pull request Apr 6, 2023

[SFP-Refactor] Fix LP mode API issue (sonic-net#247)

c2aac75

* [SFP-Refactor] Fix LP mode API issue * update API

mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024

Merge pull request sonic-net#247 from mssonicbld/submodule-202205-son…

cd41f29

…ic-utilities [submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow build image with local changes for debug purpose #247

Allow build image with local changes for debug purpose #247

taoyl-ms commented Feb 3, 2017

jleveque Feb 3, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 3, 2017 •

edited by taoyl-ms

Loading

oleksandrivantsiv Feb 3, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 3, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 3, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 3, 2017 •

edited

Loading

taoyl-ms Feb 3, 2017

taoyl-ms Feb 4, 2017

taoyl-ms commented Feb 4, 2017 •

edited

Loading

stcheng Feb 4, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 5, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 6, 2017

lguohan Feb 7, 2017 •

edited by taoyl-ms

Loading

Allow build image with local changes for debug purpose #247

Allow build image with local changes for debug purpose #247

Conversation

taoyl-ms commented Feb 3, 2017

jleveque Feb 3, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 3, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

oleksandrivantsiv Feb 3, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 3, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 3, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

taoyl-ms Feb 3, 2017 • edited Loading

Choose a reason for hiding this comment

taoyl-ms Feb 3, 2017

Choose a reason for hiding this comment

taoyl-ms Feb 4, 2017

Choose a reason for hiding this comment

taoyl-ms commented Feb 4, 2017 • edited Loading

stcheng Feb 4, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

lguohan Feb 5, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

taoyl-ms Feb 6, 2017

Choose a reason for hiding this comment

lguohan Feb 7, 2017 • edited by taoyl-ms Loading

Choose a reason for hiding this comment

jleveque Feb 3, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 3, 2017 •

edited by taoyl-ms

Loading

oleksandrivantsiv Feb 3, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 3, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 3, 2017 •

edited by taoyl-ms

Loading

taoyl-ms Feb 3, 2017 •

edited

Loading

taoyl-ms commented Feb 4, 2017 •

edited

Loading

stcheng Feb 4, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 5, 2017 •

edited by taoyl-ms

Loading

lguohan Feb 7, 2017 •

edited by taoyl-ms

Loading